Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: support extra migration packages #1510

Merged
merged 4 commits into from
Jan 24, 2024
Merged

feature: support extra migration packages #1510

merged 4 commits into from
Jan 24, 2024

Conversation

c9s
Copy link
Owner

@c9s c9s commented Jan 24, 2024

No description provided.

@bbgokarma-bot
Copy link

Welcome back! @c9s, This pull request may get 289 BBG.

@bbgokarma-bot
Copy link

Re-estimated karma: this pull request may get 299 BBG

@bbgokarma-bot
Copy link

Re-estimated karma: this pull request may get 316 BBG

@c9s c9s force-pushed the c9s/feature/extra-migration-packages branch from 428cbe7 to 3d7371a Compare January 24, 2024 07:33
@bbgokarma-bot
Copy link

Re-estimated karma: this pull request may get 321 BBG

@codecov Codecov
Copy link

codecov bot commented Jan 24, 2024

Codecov Report

Attention: 36 lines in your changes are missing coverage. Please review.

Comparison is base (4152926) 21.90% compared to head (3d7371a) 21.92%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1510      +/-   ##
==========================================
+ Coverage   21.90%   21.92%   +0.01%     
==========================================
  Files         602      602              
  Lines       43913    43922       +9     
==========================================
+ Hits         9620     9629       +9     
- Misses      33593    33596       +3     
+ Partials      700      697       -3
Files Coverage Δ
pkg/bbgo/config.go 40.30% <ø> (ø)
pkg/bbgo/bootstrap.go 0.00% <0.00%> (ø)
pkg/exchange/max/stream.go 0.00% <0.00%> (ø)
pkg/service/database.go 0.00% <0.00%> (ø)
pkg/bbgo/environment.go 1.28% <0.00%> (-0.03%) ⬇️

... and 3 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4152926...3d7371a. Read the comment docs.

@c9s c9s merged commit eb8bc94 into main Jan 24, 2024
3 of 4 checks passed
@c9s c9s deleted the c9s/feature/extra-migration-packages branch January 24, 2024 07:45
@bbgokarma-bot
Copy link

Hi @c9s,

Well done! 331 BBG has been sent to your polygon wallet. Please check the following tx:

https://polygonscan.com/tx/0x642b4f3cea30a17f316924db8730e49a8ab26c9e9dc1c5b81fcd4d3a785c31f7

Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kbearXD kbearXD kbearXD approved these changes

@bailantaotao bailantaotao bailantaotao approved these changes

@ycdesu ycdesu Awaiting requested review from ycdesu

@gx578007 gx578007 Awaiting requested review from gx578007

@narumiruna narumiruna Awaiting requested review from narumiruna

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@c9s @bbgokarma-bot @kbearXD @bailantaotao